search

alecxe / scrapy-fake-useragent

Random User-Agent middleware based on fake-useragent
MIT License
687 stars 98 forks source link

Picking different proxy types. #11

Closed medse closed 7 years ago

medse commented 7 years ago

That's a beginning, now it's possible to pass ua type to fake-user-agent. #6

lockie commented 7 years ago

Hey do you mind bumping package version on pypi so that this great improvement gets there?

alecxe commented 7 years ago

@lockie oops, I thought I did that, my bad. Will do, thanks for pinging me here.

lockie commented 7 years ago

No problem, thanks :)

alecxe commented 7 years ago

@lockie should be there on PyPI. Forgot all the sorry state (or that's just me not getting something) of packaging with PyPI, had to do it manually.. Please check.

lockie commented 7 years ago

@alecxe Thanks, it works!

The only strange thing though is that pip freeze reports package version as 1.0.4 even though it actually is 1.0.4.1, but that's pip's glitch I guess.

alecxe commented 7 years ago

@lockie right, that's because PyPI does not allow to reupload a package file with the same name, even if it happened accidentally or for a completely different package version, weird validation requirements which I had to workaround with the ".1" prefix. Sorry, thanks for noticing that.

lockie commented 7 years ago

@alecxe Oh I see. No problem :)