search

aleene / FoodViewer

An app to view and edit Open Food Fact products
Apache License 2.0
10 stars 5 forks source link

Replace Identification by the Product name, brand and weight (or the Barcode if no value) #398

Open teolemon opened 7 years ago

teolemon commented 7 years ago

image

image

image

aleene commented 7 years ago

Not sure about this one, as the title is a pane identifier and not the product identifier.

Also for the iPhone the navigationBar title is quickly to large, it will cut off must product names.

teolemon commented 7 years ago

Elipsis, or multiline. But having the tab title on this one is a waste of space, and people's attention. The first tab should be (imo) a Summary, and have the name of the product.

aleene commented 7 years ago

The summary is intended to be the products view. The first page of the pageviewcontroller is the first in depth view of part of the product. On the iPad you have the context in the master.

On the iPhone (and iPad portrait) you have a point. There the context is missing. Not so much for the first tab/page (it is a page in ios terms, tabs are something different). The other pages are missing the context even more. A better solution is needed.

Ellipses are not very nice. Multiline is not possible out of the box for the title (and not advised).

aleene commented 7 years ago

Tab bars: https://developer.apple.com/ios/human-interface-guidelines/ui-bars/tab-bars/ Pages: https://developer.apple.com/ios/human-interface-guidelines/ui-views/pages/

aleene commented 7 years ago

Related to #404

aleene commented 7 years ago

Added a page umber to the title, to make clear it is a page.

aleene commented 7 years ago

https://stackoverflow.com/questions/12190147/customize-dot-with-image-of-uipagecontrol-at-index-0-of-uipagecontrol/40938446#40938446