alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

After update no gutter icon mark #340

Closed crystalfp closed 3 years ago

crystalfp commented 3 years ago

Issue Type: Bug

After last extension update, no icon appears next to the marked line. With Ctrl-F2 the bookmark is created and appears in the sidebar, I can go to it with F2, but no icon appear in the gutter.

Here are my extension settings: image

Thanks for looking! mario

Extension version: 11.4.0 VS Code version: Code 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a, 2020-10-13T15:06:15.712Z) OS version: Windows_NT x64 10.0.19042

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|31.74GB (20.65GB free)| |Process Argv|D:\Montessori\Libro - Tecnologia in famiglia\Tecnologia in famiglia.code-workspace| |Screen Reader|no| |VM|0%|
alefragnani commented 3 years ago

Hi @crystalfp ,

I have seen some issues after extensions being updated (not only mine), and sometimes, the only way to fix it was uninstalling and installing it again (with a full VS Code quit, so VS Code actually deletes the extension from your system). But most of the times, it was related to the Side Bar icon, not from the gutter.

Just recently, a similar issue appeared (#280), and it was caused by a VS Code setting called editor.glyphMargin. Somehow, it was defined as false on user's installation.

You could try both ideas, to see if it works.

Hope this helps

crystalfp commented 3 years ago

Yes, was glyphMargin set to false the culprit. Setting it true and the bookmarks reappear. Maybe during installation/update it could be forced to true. Thanks! mario