search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

Update package.json #342

Closed fade2gray closed 3 years ago

fade2gray commented 3 years ago

Return recently missing BookMarks: Toggle Labeled command to the editor context menu.

Previous... boomarks-previous Now... boomarks-now

alefragnani commented 3 years ago

Hi @fade2gray ,

I must be missing something, but I don’t remember, neither found on source history, the Toggle Labeled command available on the Context Menu.

Which version are you referring to? Have you installed the extension from the Extensions view?

Thank you

fade2gray commented 3 years ago

Hi @alefragnani ,

Bookmarks 11.4.0 installed from Extensions view which includes package.json "version": "11.4.0".

package.json here is missing the code...

{
     "command": "bookmarks.toggleLabeled",
     "group": "bookmarks",
      "when": "editorTextFocus && config.bookmarks.showCommandsInContextMenu"
 },

I only noticed this recently and can offer no explanation.

alefragnani commented 3 years ago

But you said "recently missing", showing a print screen from a supposed previous version with that context menu item. Which version was that?

fade2gray commented 3 years ago

I don't know what the previous version was, but it would have been whatever version it was when I posted this.

I patched the current package.json file myself to create the screenshot and get the command back in the context menu.

alefragnani commented 3 years ago

Well, I’m not sure how you ended up with that on package.json (maybe you changed the sources yourself), because this command was never there.

Nevertheless, thank you for your PR. The Labeled bookmark is getting a lot of attention on recent releases, so I think this could be a good improvement.

It should be available on the next release.

fade2gray commented 3 years ago

I can only put this down to age and my increasingly failing memory and just forgot that I patched the json file to add the command to the context menu for my own convenience - but it's the kind of thing I would usually have made a feature request for.

I definitely didn't remove it - but I assume that must have happened due to an update around 17/10/2020 ? boomarks

alefragnani commented 3 years ago

No problem, it happens. I already changed some extensions myself, forgot to send a PR to the author, and lost my changes when the extension updated.

Btw, yes, version 11.4 was released October 16th.