search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

Add option to disable "No more bookmarks" notification #396

Closed zioroboco closed 3 years ago

zioroboco commented 3 years ago

Particularly when the wrapNavigation and navigateThroughAllFiles options are disabled, the "No more bookmarks" notification can come up very frequently, and can become distracting.

This adds a configuration option to disable that notification (defaulting to the existing behaviour).

Unfortunately I couldn't build the extension due to the submodule issue, but hopefully it's a simple enough change.

Thanks!

alefragnani commented 3 years ago

Hi @zioroboco ,

First of all, sorry for taking so long to answer you. It’s been a busy period.

About your PR, It’s a great addition. I have added a similar feature on my other Numbered Bookmarks extension, so I think it would use a similar naming convention.

Instead of a generic showNotifications name, the setting could be more specific, like showNoMoreBoomarksWarning.

Please, update the PR so I could test/merge for the next release.

Thank you

zioroboco commented 3 years ago

Hi @alefragnani — I've updated the PR with your suggestion. Thanks again!