search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

[BUG] - Last project bookmark cannot be removed #422

Closed ciscoheat closed 3 years ago

ciscoheat commented 3 years ago

Steps to reproduce

  1. Set "bookmarks.saveBookmarksInProject": true
  2. Add bookmarks
  3. Remove them

What happens: The last bookmark is still kept in bookmarks.json. According to the panel, no bookmarks exists, but when closing and opening VS Code, the last one appears again.

alefragnani commented 3 years ago

Hi @ciscoheat ,

First of all, sorry for the delay. It's been a busy period these days.

I could reproduce the error. It also happens not only using the Delete command in the Side Bar, but also with the Clearcommand in the Command Palette. Really weird to be failing on this scenario.

I'll take a look and hopefully fix this for the next release

Thank you for reporting

ciscoheat commented 3 years ago

Hi, no problem, I understand completely about busy times! Thanks for fixing the problem and thank you for a great extension!

alefragnani commented 3 years ago

Thank you for your understanding. I'm glad you like the extension 👍