search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

[FEATURE] - Allow Toggling Bookmark While Searching #454

Open ssigwart opened 3 years ago

ssigwart commented 3 years ago

When searching a file, bookmarks.toggle does not work. You can add editorTextFocus || findWidgetVisible to the when clause and it will bookmark it. However, the find widget loses focus. You might be able to update this line if there's a way to defect that the find widget was open.

https://github.com/alefragnani/vscode-bookmarks/blob/f9c7c1868e1d999e93447aec06e07ea6ec065e15/src/extension.ts#L681-L682

alefragnani commented 3 years ago

Hi @ssigwart,

That’s a good catch. I’m not sure there is an API to detect the Find Widget, but I’ll take a look.

Thanks