search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

[BUG] - Toggling bookmarks in notebook cells results in a duplicate editor being opened #456

Closed DonJayamanne closed 3 years ago

DonJayamanne commented 3 years ago

Environment/version

Steps to reproduce

  1. Install Jupyter extension or other extension that support notebooks
  2. Create a notebook file *.ipynb
  3. Add some code into a cell and toggle bookmarks
  4. Notice how a duplicate editor is opened for the code cell.

Thanks for this great extension. I would have submitted a PR to resolve this, however it seems the code used to add bookmarks is closed source (or its just me being silly as I was unable to find the code)

recording

alefragnani commented 3 years ago

Hi @DonJayamanne ,

I don’t use Notebooks that much, but I think I know what’s causing that. If that’s the case, it should be fixed in the next release.

Thanks for reporting

alefragnani commented 3 years ago

When I first saw your issue, I was wondering if #294 could be closed, but then I installed the .NET Interactive Notebook extension, and could see the extension is not working properly, unfortunately.

Even if the Bookmark can be added to the line, and being able to navigate between bookmarks on the same file, the List from All Files command and the Side Bar does not work. Mostly because the bookmarks are tied to the file (.ipynb) itself, not each Cell. So, Notebook support must be properly handled.

But, specifically about your issue, I just noticed it has been fixed while working on #440. So, it won't duplicate the editor anymore on the next release.

Hope this helps.