alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

[BUG] - Relabeling a bookmark from a remote SSH session fails #460

Closed carlitorendon closed 2 years ago

carlitorendon commented 3 years ago

Error running command _bookmarks.editLabel: Running the contributed command: '_bookmarks.editLabel' failed.. This is likely caused by the extension that contributes _bookmarks.editLabel.

Environment/version

Steps to reproduce

  1. Have a remote workspace with bookmarks being saved to the workspace (in the configuration)
  2. From a remote workspace IDE session, create a bookmark (this is fine)
  3. Try to re-label it, you get this error:

Error running command _bookmarks.editLabel: Running the contributed command: '_bookmarks.editLabel' failed.. This is likely caused by the extension that contributes _bookmarks.editLabel.

alefragnani commented 3 years ago

HI @carlitorendon ,

First of all, sorry for the late response.

I don't use SSH, but does have WSL and Docker available, and it should work the same way. Unfortunately, I couldn't reproduce the error, but I remember seeing something similar issue even with basic/local sessions. Weirdly enough, I didn't reproduce that as well, so I have to dig a bit more to find out what's that scenario.

I remember it was related to rename some bookmark other than the current/focused file. I mean, you are editing fileA.txt and rename the label (using Context Menu or the inline button) of fileB.txt. I would ask you two things:

  1. Update the extension to 13.2 and try again.
  2. If the error persist, renaming the label using Command Palette, instead of the TreeView

Hope this helps

alefragnani commented 2 years ago

I'm closing this issue because no new comments has been added since my last question. Feel free to reopen/comment if the error still occurs.

Thanks for your understanding

carlitorendon commented 2 years ago

Hello @alefragnani I also apologize for the late reply. Yeah I agree, let's close it for now and if this gain traction we can revisit. Thank you for this good plugin

alefragnani commented 2 years ago

That's ok, no need to apologize 🤝

Thank you