alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

[FEATURE] - Document keyboard shortcuts in the README #467

Open brentgti opened 3 years ago

brentgti commented 3 years ago

Those less familiar with Visual Studio Code don't know or remember to use ctrl-shift-p to look up Bookmarks commands and see their associated keybindings, but often instead search online. It would help those people to have the keybindings documented in the README.

As an aside, I don't see the keybinding for "jump to next" when I look it up using ctrl-shift-p in Code. I don't know if that's because of something I did. When I go to the settings for that command, I do see the keybinding.

image

alefragnani commented 3 years ago

Hi @brentgti ,

Sometime ago I decided to avoid using (and documenting) shortcut keys on my extensions, basically because:

So yes, if you want to know the available shortcuts, you need to open the Command Palette and filter the commands typing Bookmarks.

But, I’m open to PRs. The only difference is that instead of adding the shortcuts in the README file, it should use a similar idea from the VSCode team, which has created a separate documentation for each OS (https://code.visualstudio.com/docs/getstarted/keybindings#_keyboard-shortcuts-reference).

As an aside, I don't see the keybinding for "jump to next"

This is its shortcut definition:


{
    "command": "bookmarks.jumpToNext",
    "key": "ctrl+alt+l",
    "mac": "cmd+alt+l",
    "when": "editorTextFocus"
},

It’s probably conflicting with another extension. Open the Keyboard Shortcut command and look for the shortcut. It should shows you all commands that has this shortcut. If I remember correctly, VS Live Share was one of the extensions that registered the same shortcut keys after a few releases. The Bookmarks extension was released on day one of VS Code 😬 .

Hope this helps

rohmanservice1 commented 2 years ago

saya belum mengerti peng .gunaan ,akrya malah rusak semua ,total eror

amzar96 commented 1 year ago

Hi @alefragnani , is there any luck to custom the shortcut?

alefragnani commented 1 year ago

Hi @amzar96,

You can customize any keyboard shortcut an extension provides. Simply follow the Official documentation.

Hope this helps