search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.68k stars 163 forks source link

[BUG] - Bookmarks prevent clicks on breakpoints #551

Closed shaonianruntu closed 2 years ago

shaonianruntu commented 2 years ago

Environment/version

Steps to reproduce

Normally, a click can creates a breakpoint, and clicks the breakpoint again can cancel it.

But when a bookmark is created on the line where the breakpoint is located, the bookmark will overwrite the layer of the breakpoint, and clicking the created breakpoint again cannot cancel it. You can continue to cancel the breakpoint by clicking only if you unbookmark the current line first.

image

I think it's a bug, bookmarks shouldn't override mouse actions on the current line breakpoint.

Hoping to fix it,

Thanks & Regards Nan

fade2gray commented 2 years ago

You can use the Run -> Toggle Breakpoint from the menu, or use the F9 hotkey.

alefragnani commented 2 years ago

Hi @shaonianruntu ,

This issue is caused by VS Code (first reported in #56), and unfortunately, there is nothing I can do on my side. The extension doesn't have any control about the click event. In fact, I wish I had, because I could add a add bookmark with mouse click option 😃

It is being tracked in https://github.com/microsoft/vscode/issues/5923, and besides the original visual issue has been partially solved by VS Code, the click still doesn't.

So, we just have to wait until VS Code itself fixes it, or expose any click event handler to extensions.

Hope this helps

@fade2gray thanks for the tip 👍

shaonianruntu commented 2 years ago

Hi @shaonianruntu ,

This issue is caused by VS Code (first reported in #56), and unfortunately, there is nothing I can do on my side. The extension doesn't have any control about the click event. In fact, I wish I had, because I could add a add bookmark with mouse click option 😃

It is being tracked in microsoft/vscode#5923, and besides the original visual issue has been partially solved by VS Code, the click still doesn't.

So, we just have to wait until VS Code itself fixes it, or expose any click event handler to extensions.

Hope this helps

@fade2gray thanks for the tip 👍

Thank you very much for your detail reply.

Hahaha, I am real confused why we can't add a breakpoint by mouse click before. Seems it is a missing function of VSCode.

Thank you

sslupsky commented 2 years ago

@alefragnani What about the margin on the other side of the line number where the expand / collapse code section controls are located? Can you get a click event there? If that is possible, maybe it is possible to move the bookmark here instead of using the gutter?

alefragnani commented 2 years ago

Hi @sslupsky , unfortunately no, it is not possible either.