alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.65k stars 161 forks source link

[BUG] - bookmarks.json file dissapeared shortly after enabling bookmarks.saveBookmarksInProject #618

Closed vbrozik closed 12 months ago

vbrozik commented 1 year ago

I am normally using VS Code preview but I needed to use the normal release. I noticed that I do not see my bookmarks in my normal release. So I did the following:

Environment/version

Steps to reproduce

  1. enable bookmarks.saveBookmarksInProject in VS Code preview (setting synchronization is on)
  2. close VS Code preview
  3. start VS Code normal release
  4. the file .vscode/bookmarks.json is gone and all bookmarks are lost
alefragnani commented 1 year ago

Hi @vbrozik ,

AFAIK, settings sync does not work between different releases, which means that the setting you defined in Insiders won’t be available in Stable and vice versa. The expected behavior in this case would be Stable release simply ignore the bookmarks from .vscode/bookmarks.json file, but not delete the file. In order to delete the .vscode/bookmarks.json file, two things must happen:

But even if you change the setting from true to false, the .vscode/bookmarks.json won’t be deleted.

If you need the bookmarks to be portable, no matter which VS Code release you are using, you should define the saveBookmarksInProject setting in the folder. Doing so, VS Code will save a .vscode/settings.json file within the project/folder and whenever you open that folder, those settings will be loaded and used.

Hope this helps.

alefragnani commented 12 months ago

I'm closing this issue because no new comments has been added since my last question. Feel free to reopen/comment if the error still occurs.

Thanks for your understanding