alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.7k stars 163 forks source link

[BUG] - Command `workbench.view.extension.bookmarks` #641

Closed CAESIUS-TIM closed 1 year ago

CAESIUS-TIM commented 1 year ago

image

Should open and focus bookmarks in the sidebar, but open the explorer and remain the focus in the editor. Key bindings do not conflict.

Environment/version

Steps to reproduce

  1. bind key for View: Show Bookmarks (workbench.view.extension.bookmarks)
  2. use the binding
CAESIUS-TIM commented 1 year ago

image

View: Show Bookmarks isn't in commands picker. Maybe workbench.view.extension.bookmarks is a command belongs to the explorer of vscode itself, and the extension bookmarks has no the feature.

CAESIUS-TIM commented 1 year ago

https://github.com/alefragnani/vscode-bookmarks/blob/fbc289be97ca4d376a8c1d599c93b9d6b024f137/README.md?plain=1#L54-L67

Maybe it should be a feature request issue rather than a bug issue. I'm grateful if someone can help me confirm this.

CAESIUS-TIM commented 1 year ago

bookmarksExplorer.focus

CAESIUS-TIM commented 1 year ago

bookmarksExplorer.focus

But View: Show Bookmarks (workbench.view.extension.bookmarks)?

alefragnani commented 1 year ago

Hi @CAESIUS-TIM ,

These commands (bookmarksExplorer.focus and workbench.view.extension.bookmarks) are created automatically (and controlled by) VS Code, and I have no control on it. But, it is strange that it does not work for you, as I have the same shortcut on my setup, but using:

    {
        "key": "shift+cmd+r",
        "command": "workbench.view.extension.bookmarks",
        "when": "isMac"
    },

If you are sure there is no conflict, you could confirm using Developer: Toggle Keyboard Shortcut Troubleshooting (https://code.visualstudio.com/docs/getstarted/keybindings#_troubleshooting-keybindings) to try discover what is happening. If you have no success, I suggest you to open an issue in VS Code repo (https://github.com/microsoft/vscode/issues/new/choose), reporting the issue.

Unfortunately, there is nothing I can do on my side to fix it. At least, not that I'm aware of.

Hope this helps

ckx commented 9 months ago

I'm also experiencing this issue on 1.85.1, Fedora 38.

This is a shot in the dark but I noticed in this repo's README the Bookmarks side bar looks like this, which I assume is macOS:

image

For me it's formatted this way:

image and this is the vs code explorer sidebar: image

This is a fairly weak assumption, but maybe the fact that on our operating systems, the sidebar title having EXPLORER in it is the reason @CAESIUS-TIM and I keep having the VS code explorer open? I don't have a vscode development environment setup atm so I can't test, but if @alefragnani has time to do a simple string search/replace of "explorer" and send me over a vsix I can test the theory.

ckx commented 9 months ago

This was incidentally fixed through another bugfix in the current insiders https://github.com/microsoft/vscode/issues/200889.