alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.65k stars 161 forks source link

[BUG] - Labeled bookmarks no longer stay at the top of the list / (new bookmarks not always added to bottom of the list?) #657

Closed Dustin-Digitar closed 8 months ago

Dustin-Digitar commented 8 months ago

Up until the last patch, bookmarks I had labled stayed at the top of my bookmarks list. This made them easy to find in the list. After the last patch, new bookmarks I add sometimes get added above the labeled bookmarks. I am not sure if this is because labeled bookmarks were stickied at the top, or because new bookmarks were always added to the bottom. In any case, the previous behavior is preferred.

Steps to reproduce

  1. Create a bookmark
  2. Give it a label by clicking on the pencil icon next to it in the bookmarks list in the bookmarks pane
  3. Add a new bookmark anywhere
  4. Sometimes that new bookmark will be above the labeled bookmark
alefragnani commented 8 months ago

Hi @Dustin-Digitar ,

The extension doesn't support sorting feature, as the bookmarks are always listed by line number, no matter if it is a regular or labeled bookmark. What you had probably faced in the past was a coincidence, where your labeled bookmarks were already at the top of the file. In fact, there are two open issues (#217 and #435) related to sorting.

I'm not sure how you accomplish this. Maybe you were using a different Bookmarks extension in the past?

Hope this helps

Dustin-Digitar commented 8 months ago

Hmm, you should know how it works, but it's also hard to believe that over a few years of using this bookmarks extension that coincidentally the labeled bookmarks were just always at the top of the file.

A few years ago you said the order was by "bookmark toggles" https://github.com/alefragnani/vscode-bookmarks/issues/435#issuecomment-850737245

In any case, the addition of a sorting feature should provide what I am looking for. So this issue can be closed.