search

alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.65k stars 161 forks source link

[BUG] - bookmarks.label.suggestion doesn't take the selected text #693

Closed manuel-jasso closed 3 months ago

manuel-jasso commented 5 months ago

First: thank you for such a useful extension! 👍🏼

Environment/version

Steps to reproduce

  1. Configure bookmarks.label.suggestion to be useWhenSelected
  2. Select some text
  3. Toggle bookmark

Result: the bookmark is created, but it is not labeled with the selected text.

More info: I tried removing and reinstalling the extension, but no luck.

alefragnani commented 4 months ago

Hi @manuel-jasso ,

First of all, thank you for you kind words. I'm glad to know the extension is helpful.

About your issue, it seems you are using the wrong command. There is an specific command for labeled bookmarks, which is called Bookmarks: Toggle Labeled. This command is the one to be used when you want to work with bookmarks that contains commands. That setting is used only in this command.

Could you take a look and try out with this command instead? Thank you

Hope this helps

alefragnani commented 3 months ago

I'm closing this issue because no new comments has been added since my last question. Feel free to reopen/comment if you have more details

Thanks for your understanding