alefragnani / vscode-bookmarks

Bookmarks Extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=alefragnani.Bookmarks
GNU General Public License v3.0
1.72k stars 165 forks source link

[FEATURE] - I would love to have a similar extension to this in Azure Data Studio. #725

Closed Chewieez closed 3 months ago

Chewieez commented 6 months ago

I've enjoyed using this Bookmarks extension in VS Code and I frequently wish I had a similar extension in Azure Data Studio when working in large .sql files.

alefragnani commented 4 months ago

Hi @Chewieez ,

Have you tried to install the extension in ADS, using the instructions? The .vsix file is available in the VS Code Marketplace page (https://marketplace.visualstudio.com/). I remember some of my extensions worked on it, when I discovered about ADS, but I'm not entirely sure which one.

ADS itself has no marketplace, and any third party extension must be contributed directly to ADS. There is an open issue in the ADS repo (https://github.com/microsoft/azuredatastudio/issues/3874) asking for an improvement in the extension marketplace, but I'm not sure about ETA.

I'll wait until ADS has a smoother marketplace experience, in order to try out porting Bookmarks to it.

Hope this helps

Chewieez commented 4 months ago

Whoa, I never thought to try installing a VS Code extension into ADS. It makes sense now that I think about it.

It does work just by installing it in ADS. The area to the left of the editor, for breakpoints in VS Code, is not interactive in ADS, so you need to right click inside the text area to toggle a bookmark, or use the keyboard shortcut. But once you have a bookmark, navigating to it and deleting it via the sidebar tab works normally.

Thanks for the tip!

alefragnani commented 3 months ago

That's probably because ADS uses an outdated VS Code version, which does not yet support context menu in gutter. And also, ADS may have its own extensibility and some features may not be available/supported.

Lets wait and see how it evolve in the future