search

alefragnani / vscode-copy-word

Copy Word Extension for Visual Studio Code
MIT License
11 stars 4 forks source link

Added support for paste. #41

Closed dudeNumber4 closed 2 years ago

dudeNumber4 commented 2 years ago

I just can't figure out how to debug my command. I don't know how/where registerCommands is supposed to get called. Reference feature request. Disregard - I had never run vscode:prepublish

alefragnani commented 2 years ago

Hi @dudeNumber4 ,

First of all, thank you for your PR. I made a few comments, and would like you to take a look. Those 3 files README.md, CHANGELOG.md and package-lock.json could be reverted (removed from PR) and only package.json needs update. The extension's code itself, seems to be ok.

About debugging, I've noticed this issue after updating the extension to use esbulid. It requires you to be built (npm run build) every time you update the code, because there it has no watch feature. I'm reverting this change in #43 , because web extension samples uses WebPack for easier packaging. With WebPack, which scripts supports watch, whenever you change the code, the debug works as expected.

I can merge #43 into main, so you could update your branch and retry with WebPack. Otherwise, simply follow these esbuild instructions to properly debug the extension. What do you prefer?

Thank you

dudeNumber4 commented 2 years ago

I was able to debug; it should be good to merge.

dudeNumber4 commented 2 years ago

Is there anything else blocking this from being merged?

alefragnani commented 2 years ago

Not at all.

Just my free time to test/merge 😉

alefragnani commented 2 years ago

My plans are for this weekend

alefragnani commented 2 years ago

Just published v3.7.0 with your PR.

This new release also works on the web (github.dev and vscode.dev)

Thank you