search

alefragnani / vscode-jenkins-status

Jenkins Status Extension for Visual Studio Code
MIT License
27 stars 20 forks source link

Suggestion: Configure Jenkins URL in workspace settings #9

Open ilkka opened 7 years ago

ilkka commented 7 years ago

When deciding on putting the config into a .jenkins file, did you consider adding custom plugin-specific config into the VS Code workspace settings file instead? My first thought is that since this configuration is both project and VS Code specific, that would be the natural place. Or does some other tool use .jenkins files also? Don't get me wrong, I don't think it's bad, this is just me thinking aloud really :)

alefragnani commented 7 years ago

Hi @ilkka ,

The main reason is because I created the extension based on the idea of the Travis. It needs to have the configuration file in the root folder because is how the Travis integration works (of course, its file has much more info than mine :smile: ). It was my base model. Also, because the VSCode activation based on file existence only works for files in root folder.

Sure, it could be moved/selected another location for the file . The only downside would be the activation (overall performance), but it's no a big deal.