search

alefragnani / vscode-jenkins-status

Jenkins Status Extension for Visual Studio Code
MIT License
27 stars 20 forks source link

Remove unnecessary JenkinsIndicatorController class #96

Closed md2perpe closed 1 year ago

md2perpe commented 1 year ago

What is the meaning with the class JenkinsIndicatorController in JenkinsIndicator.ts? It seems to not do anything, not even collect things. The field jenkinsIndicator is set but never read, while the field disposable is read but never set.

alefragnani commented 1 year ago

Hi @md2perpe ,

Indeed, it is unnecessary today. It could be removed from the sources.

Did you noticed while building/debugging the extension?

alefragnani commented 1 year ago

A PR would be welcome, btw 😄

md2perpe commented 1 year ago

I noticed while reading and trying to understand the source.

md2perpe commented 1 year ago

Pull request #97 created.