Master - Githubissues

alefragnani / vscode-project-manager

Project Manager Extension for Visual Studio Code

GNU General Public License v3.0

1.96k stars 228 forks source link

Master #747

Closed GLxBOTAi closed 5 months ago

GLxBOTAi commented 5 months ago

Refactor codebase to adapt to V3 API changes

Replaced deprecated functions from V2 with their V3 counterparts.
Updated function signatures to match the new V3 API.
Cleaned up code to remove obsolete V2-specific logic.

GLxBOTAi commented 5 months ago

add unit test for user model

GLxBOTAi commented 5 months ago

Great job! The changes look good to me and everything is working as expected. The code is clean and follows our project guidelines. I'm approving this pull request. 👍

GLxBOTAi commented 5 months ago

Thanks for the updates! I noticed a few areas that need improvement before we can merge this:

In user_model.js, the function validateUser should include additional checks for user roles.
The new unit tests for the user model look good, but we need to add tests for edge cases as well.

Please make these changes and update the pull request. Let me know if you have any questions!