search

aleho / gnome-shell-volume-mixer

GNOME Shell Extension allowing separate configuration of PulseAudio devices
https://extensions.gnome.org/extension/858/volume-mixer/
GNU General Public License v2.0
136 stars 32 forks source link

Always hide input indicator #141

Closed luk1337 closed 2 years ago

luk1337 commented 3 years ago

This gets rid of unnecessary space between volume and power icon.

luk1337 commented 3 years ago

Before: image

After: image

luk1337 commented 3 years ago

@aleho mind taking a look at this change? ^^

illnyang commented 2 years ago

The issue only arises when Always show input streams is enabled, at least on my setup.

luk1337 commented 2 years ago

@kvdrrrrr it actually happens whenever input indicator is supposed to shown past extension initialization.

aleho commented 2 years ago

This is not a good idea I think, because it unconditionally disables the input indicator.

Have a look at current main. I think the last commit should fix your problem.

luk1337 commented 2 years ago

@aleho the issue is still present as gnome input indicator is just not working. With extension off: image With extension on: image ( after alt+f2 r ) image

aleho commented 2 years ago

I've now streamlined and matched input indicator handling with upstream Gnome.

luk1337 commented 2 years ago

@aleho FYI, "Always show input streams" still doesn't work the way it should. I believe it should only always show the volume slider, but as of now it also constantly shows the microphone indicator even if nothing is recording it.

aleho commented 2 years ago

I'm aware of the missing label, thanks!

Constantly showing the indicator is done on purpose though.