search

aleho / gnome-shell-volume-mixer

GNOME Shell Extension allowing separate configuration of PulseAudio devices
https://extensions.gnome.org/extension/858/volume-mixer/
GNU General Public License v2.0
136 stars 32 forks source link

Extension makes assumation where python3 is located #153

Closed rhoriguchi closed 2 years ago

rhoriguchi commented 2 years ago

This extension assumes that python is located under /usr/bin/env, which is not the case in all distros. It would be better to check all dirs in the environment variable PATH.

https://github.com/aleho/gnome-shell-volume-mixer/blob/b8b0bc58ec920432366fdfed365475e83e88cab9/shell-volume-mixer%40derhofbauer.at/lib/utils/paHelper.js#L28

https://github.com/aleho/gnome-shell-volume-mixer/blob/b8b0bc58ec920432366fdfed365475e83e88cab9/shell-volume-mixer%40derhofbauer.at/lib/utils/paHelper.js#L66

PR to patch this NixOS/nixpkgs#154692

aleho commented 2 years ago

That's actually incorrect.

Python is not located under /usr/bin/env, env is used to determine the location of the Python installation. That's a standard way of determining the installation path in Linux.

I'm not going to implement work-arounds for broken setups via a custom PATH lookup for the few instances where env might not be available or point to the wrong Python executable.