search

aleho / gnome-shell-volume-mixer

GNOME Shell Extension allowing separate configuration of PulseAudio devices
https://extensions.gnome.org/extension/858/volume-mixer/
GNU General Public License v2.0
135 stars 32 forks source link

Explicitly call toString() on Uint8Array #92

Closed tingvarsson closed 6 years ago

tingvarsson commented 6 years ago

Correction based on warning given with gnome shell 3.30: "Some code called array.toString() on a Uint8Array instance. Previously this would have interpreted the bytes of the array as a string, but that is nonstandard. In the future this will return the bytes as comma-separated digits. For the time being, the old behavior has been preserved, but please fix your code anyway to explicitly call ByteArray.toString(array)."

tingvarsson commented 6 years ago

Fixes #90

tingvarsson commented 6 years ago

Just realized this will not work pre-3.30. Do you want a solution that handles both cases? Or just step the supported versions to only 3.30+?

tingvarsson commented 6 years ago

Tweaked the fix to also handle pre 3.30 cases properly.

aleho commented 6 years ago

Thanks, looks good!

tingvarsson commented 6 years ago

Sorry for the typo. Most have corrected locally but not amended it to github.

aleho commented 6 years ago

No worries, thanks for the PR anyway!

tingvarsson commented 6 years ago

No problem. Glad I can contribute.