search

aleho / gnome-shell-volume-mixer

GNOME Shell Extension allowing separate configuration of PulseAudio devices
https://extensions.gnome.org/extension/858/volume-mixer/
GNU General Public License v2.0
135 stars 32 forks source link

Fix for: https://github.com/aleho/gnome-shell-volume-mixer/issues/42 #93

Closed alexandrupetrini closed 5 years ago

alexandrupetrini commented 5 years ago

Fixed or proposed a fix for that bug.

aleho commented 5 years ago

There are loads of issues with this PR.

First of all: a heap of files you committed from an old version. You should rather check out the git repository and start hacking away there, instead of copy/pasting the GNOME distribution of this extension.

Then there's an issue with the solution itself: You should not introduce a global variable for a label that might be shared between multiple widgets and get overwritten. This extension uses classes, so that's the correct starting point for hacking away.

Then there are two commits for actually only a few lines of changes. And no commit message describing the reason for them. What was the intention of changing it? Document that in a commit message.

Finally, after a heavy rewrite the conflicts of this PR would not resolve at all, so a rebase is needed as a starting point.