alehouse / cantata

Automatically exported from code.google.com/p/cantata
GNU General Public License v3.0
1 stars 0 forks source link

add ability to specify custom sources for lyrics / don't save text "Submit Lyrics Your name will be printed as part of the credit when your lyric is approved." #619

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which version of Cantata? most recent

Which build? KDE, Qt4, Qt5, Windows, Ubuntu, Mac? Qt5

What steps will reproduce the problem?
1. Play song without lyrics
2. Open open info tab.
3.

What is the expected output? What do you see instead?
When none of the sites searched have lyrics, it displays "Submit Lyrics
Your name will be printed as part of the credit when your lyric is approved." 
and saves this to file (if that option is enabled).

What would be better is not to display or save the text "Submit Lyrics
Your name will be printed as part of the credit when your lyric is approved." 

Please provide any additional information below.

Can an option be added to be able to customise the lyrics sites searched?  E.g. 
to be able to add new sites and specify a preferred order for searching.

Original issue reported on code.google.com by be.sla...@gmail.com on 26 Jan 2015 at 2:31

GoogleCodeExporter commented 9 years ago
version = 1.5.1

Original comment by be.sla...@gmail.com on 26 Jan 2015 at 2:33

GoogleCodeExporter commented 9 years ago
The text "Submit Lyrics
Your name will be printed as part of the credit when your lyric is approved."  
is comming from a lyrics provider - it is not part of Cantata.

You can add your own providers - but this is a non-trivial thing to do. You 
need to know how to 'scrape' the side to return just the lyrics text.

Cantata's list of providers is taken from each lyrics_*.xml file in 
~/.local/share/cantata/config, and INSTALL/share/cantata/config

You would need to look at one of those files, and create a new entry for the 
site you'd like to add.

If you do this and you want it added to Cantata itself, so as to be usable by 
others, please jsut send me your updated/added file.

Original comment by craig.p....@gmail.com on 1 Feb 2015 at 12:48