alehouse / cantata

Automatically exported from code.google.com/p/cantata
GNU General Public License v3.0
1 stars 0 forks source link

Weird bug in reading/writing/saving ratings #647

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Which version of Cantata?
r5687

Steps:
0.  Connect to a remote MPD server whose collection is duplicated on the local 
machine.
1.  Find an unrated track.
2.  Open track information dialog.
3.  Rate and Save the track.
4.  See that the rating is now listed in the Rating column.
5.  Reopen the track info dialog.
6.  See that the rating field is empty.
7.  Tools->Write Ratings to file
8.  Check the file with mediainfo and see that the rating was indeed written to 
the file, even though the info dialog displays an empty rating.

Original issue reported on code.google.com by alphadel...@gmail.com on 27 Feb 2015 at 10:48

GoogleCodeExporter commented 9 years ago
So, I guess you are now saying #641 is invalid? As you *can* save the ratings?

Original comment by craig.p....@gmail.com on 27 Feb 2015 at 12:12

GoogleCodeExporter commented 9 years ago
I think the ratings were saved, just the dialog not working correctly when a 
single track is selected.

Please update - is it now fixed?

Original comment by craig.p....@gmail.com on 27 Feb 2015 at 6:24

GoogleCodeExporter commented 9 years ago
No, issue 641 is about saving ratings to the database on a remote MPD instance, 
in which it apparently doesn't save them to the database at all.  In this 
issue, the ratings are saved to the database (connected to a local MPD, not a 
remote one), but the track info dialog does not seem to display the new rating.

I'll build r5697 and try it out.

Original comment by alphadel...@gmail.com on 28 Feb 2015 at 1:18

GoogleCodeExporter commented 9 years ago
I just realized that I contradicted my step 0 in my last comment.  Let me check 
into this...

Original comment by alphadel...@gmail.com on 28 Feb 2015 at 2:33

GoogleCodeExporter commented 9 years ago
Yes, this issue does seem to be fixed now.  Thanks.

And yes, I think issue 641 is fixed also.

While we're talking about ratings, let me mention one small thing that is 
probably not a bug, but you might want to consider.  Just now I was connected 
to a remote MPD, and I loaded ratings from file for all the tracks in the 
playlist.  Then I saved them to the database.  That worked, and then the 
ratings started appearing in the Rating column in the Play Queue.  Awesome.  :) 

What I am curious about is, the ratings appear slowly, one at a time.  
Eventually they all appear, so it is working correctly.  But when I connect to 
a different MPD server, and then connect back to the first one, the ratings 
appear all at once for all of the files.  So I wonder if you might want to 
batch this process together somehow.  However it's doing the query on initial 
connection, it seems like it could do the same thing here.

No big deal, really, but let me know if you want me to file this as an issue.  
Thanks.

Original comment by alphadel...@gmail.com on 28 Feb 2015 at 2:44

GoogleCodeExporter commented 9 years ago

Original comment by craig.p....@gmail.com on 28 Feb 2015 at 5:08