search

alejandro-du / crudui

Automatically generate CRUD-like Vaadin views for any Java Bean
https://vaadin.com/directory#!addon/crud-ui-add-on
Apache License 2.0
85 stars 52 forks source link

External notifications #11

Closed urkl closed 5 years ago

urkl commented 7 years ago

Hi Alejandro, as an idea, it would be nice, to add a possibility to externelize notifications, or to overide them.

alejandro-du commented 7 years ago

Hi, that's true. I thought about removing the notifications altogether as it should be possible to manually add them in the CRUD listener implementations. However, I want to provide as much out-of-the-box functionality as possible, so maybe a method such as setNotificationsVisible(boolean) would be a better idea.

urkl commented 7 years ago

Your idea is definitely better. And another question/idea would be implementing inline grid editor? Have you ever thought about it?

alejandro-du commented 7 years ago

I thought about it but discarded it. There wouldn't be much for the add-on to offer because the Grid itself has the required features.

alejandro-du commented 5 years ago

Fixed for GridCrud. Call ´showNotifications(false)to disable notifications or overrideGridCrud.showNotification(String)` to provide a custom implementation.