search

alejandro-du / crudui

Automatically generate CRUD-like Vaadin views for any Java Bean
https://vaadin.com/directory#!addon/crud-ui-add-on
Apache License 2.0
85 stars 54 forks source link

Fix base field provider interface generics #110

Closed bonifacechacha closed 1 year ago

bonifacechacha commented 1 year ago

Hi,

I have fixed the generic definition on the FieldProvider interface which initially

  1. was defined with an incorrect type
  2. not used in the method definitions
alejandro-du commented 1 year ago

Sorry, can you rebase so I can test and merge? Did you test your changes with the included demo app?

bonifacechacha commented 1 year ago

Yes. So I have changed the java version for both the addon and demo to use java 11 since we are building using vaadin 23.

bonifacechacha commented 1 year ago

At first i included the changes for supporting java 11 instead of 1.8. But i have removed them to fix this pull request and I have created a different pull request for migrating the addon from 1.8 to 11.

alejandro-du commented 1 year ago

Thanks for the contribution!