search

alejandro-du / crudui

Automatically generate CRUD-like Vaadin views for any Java Bean
https://vaadin.com/directory#!addon/crud-ui-add-on
Apache License 2.0
85 stars 54 forks source link

If Update Action throws IllegalArgumentException Exception is swallowed #113

Closed dwlabcube closed 10 months ago

dwlabcube commented 1 year ago

If the Action in Line 193 throws an IllegalArgumentException (for reasons that are within the updateOperation (for Example an Enum-Entry can not be found by Name or whatever custom logic might throw an IllegalArgumentException) then it simply disappears.

image

I am sure that line of code is there for a reason, but maybe one should catch a more specific Exception instead all IllegalArgumentException in that line. Otherwise Exceptions thrown by DatabasePersistence or Processing the UpdateOperation are just swalloed and the user thinks everything is saved.

alejandro-du commented 1 year ago

Good catch! I'll have to look at it at some point. Or if someone has time to investigate this and contribute a patch, welcome!