search

alejandro-du / crudui

Automatically generate CRUD-like Vaadin views for any Java Bean
https://vaadin.com/directory#!addon/crud-ui-add-on
Apache License 2.0
86 stars 54 forks source link

Lazy find all operation limits the use of provider to be of format generics DataProvider<T,Void> only instead of DataProvider<T,?> #54

Closed bonifacechacha closed 5 years ago

bonifacechacha commented 5 years ago

The interface LazyFindAllCrudOperationListener requires DataProvider<T, Void> on its getDataProvider() which prevents other implementations which does not use Void as a filter on the second generic. This could be resolved by making the interface be as:

public interface LazyFindAllCrudOperationListener<T> extends FindAllCrudOperationListener<T> {
    DataProvider<T, ?> getDataProvider();
}

Vaadin grid method for setting DataProvider requires DataProvider<T, ?> which I assume with the implementation above it will still work.

alejandro-du commented 5 years ago

Fixed. Thanks for your contribution!