alejandro5042 / azdo-userscripts

A collection of userscripts to improve the Azure DevOps UI
https://alejandro5042.github.io/azdo-userscripts/
MIT License
40 stars 23 forks source link

Not working because of tippy.js exception #205

Closed jerone closed 1 year ago

jerone commented 1 year ago

The userscript is not working for some time now. Today I investigated why this happened. After some debugging I found out that the included resource tippy.js was the issue (see screenshot).

Removing the following line from the source make the userscript working again.

// @require      https://unpkg.com/tippy.js@6#sha384-AiTRpehQ7zqeua0Ypfa6Q4ki/ddhczZxrKtiQbTQUlJIhBkTeyoZP9/W/5ulFt29

I have verified this on my work and personal account.

Logs

image

Context

alejandro5042 commented 1 year ago

Ugh, that's no good.

I just checked with latest Microsoft Store version of Firefox 108.0.1 (64 bit) on Windows 10 -- userscript works. Using Violentmonkey 2.13.3.

The userscript is also working on Chrome/Edge.

Could you try with Violentmonkey and see if it works? If not, could you try upgrading Firefox to 108?

Let's try to isolate this issue and fix it for ya!

jerone commented 1 year ago

Updating to Firefox 108 didn't change anything.

I tried changing the way the script is loaded with run-at (document-start, document-body, document-end, document-idle, ...); no success.

I tried Tampermonkey Beta; no success.

I tried Violentmonkey, which does work. Just not happy about its security:

This add-on is not actively monitored for security by Mozilla. Make sure you trust it before installing.

Based on this comment, it looks like an race-condition:

@popperjs/core must always be loaded before tippy.js

Sadly, Tampermonkey's documentation doesn't mention anything about the order of loading of @require headers.

kroeschl commented 1 year ago

@jerone This appears to be working with script version 3.6.0, which bumped the version of tippy.js. I tested with:

jerone commented 1 year ago

Yes, I can confirm, after switching back from Violentmonkey to Tampermonkey, that the latest version (3.6.0) is working correctly again.

Thank you for letting me know.