search

alejandroautalan / pygubu-designer

A simple GUI designer for the python tkinter module
GNU General Public License v3.0
803 stars 98 forks source link

try except on import? #94

Closed matecsaj closed 2 years ago

matecsaj commented 2 years ago

In some example code, I noticed the following.

try:
    import tkinter as tk
except:
    import Tkinter as tk

Should the code generator be doing that?

rdbende commented 2 years ago

In my opinion not. It's just for compatibility with Python 2, but since it reached End of Life in January 2020, new code shouldn't support it. Especially because Pygubu wants to drop Python 2 support (#75)

alejandroautalan commented 2 years ago

In some example code, I noticed the following.

try:
    import tkinter as tk
except:
    import Tkinter as tk

Should the code generator be doing that?

Hello Peter, Those examples were created manually, before the code generator existed in the designer. The code generator always creates python3 code. I will update and remove python 2 stuff.

Regards Alejandro A.