search

alejandrom1999 / moodle_tfg

0 stars 1 forks source link

files contain mix of inline php code and functions that do not follow frankenstyle naming rules #10

Open danmarsden opened 9 months ago

danmarsden commented 9 months ago

eg: https://github.com/alejandrom1999/moodle_tfg/blob/main/objetivos/form_asignar_tarea.php#L15

Functions should sit within namespaced classes, or a locallib.php file and if not in namespaced classes, they need to follow the frankenstyle naming rules: https://moodledev.io/general/development/policies/codingstyle/frankenstyle#function-names

note this is a blocker for plugins db approval.

danmarsden commented 9 months ago

also watch out for the same sorts of issues with your classes eg: https://github.com/alejandrom1999/moodle_tfg/blob/main/objetivos/classes/form/form_asignar_tarea.php#L4

the class should be namespaced within block_objetivos OR it should have the frankenstyle prefix on the class name.