dockerization, makefile and some fixes

alejoar / factorialsucks

FactorialHR auto clock in for the whole month from the command line

28 stars 9 forks source link

dockerization, makefile and some fixes #4

Open svg153 opened 2 years ago

svg153 commented 2 years ago

We began to use factorial, to control working hours, and we had to enter the hours from the beginning of the year. To do this, we use this tool, and we dockerize it. We also created some common targets. With this, we were able to enter the hours from any environment and person.

So, here is the PR, in case you want to integrate it.

Thank you very much for the tool. All the best.

alejoar commented 2 years ago

Hi @svg153

Thank you for this contribution.

I think I understand the advantages of dockerizing, however I would like to keep the main usage of the app as a standalone/installable binary. I already include binaries for most platforms with each release, have you seen those in the releases page?

In any case, can you please update the Readme file so that anything related to Docker is in a separate section under the current contents? I think that would be enough to merge this.

svg153 commented 2 years ago

Hi @alejoar.

I updated the branch with these changes:

Move Docker information in README.md to a separate section (Docker) under the current content.
Create new Makefile targets that use native build.
Rename Docker Makefile targets.
Add factorialsucks binary created by native build in the root of the repository to .gitignore.

Thanks.