search

alejolp / extmodem

Sound card modem for Amateur Radio AX25
43 stars 11 forks source link

Added UNPROTO VIA frame support to AGWPE TCP server #10

Closed gherynos closed 8 years ago

gherynos commented 8 years ago

Hi @alejolp :)

I added a piece of code that handles the 'V' frame type in the AGWPE interface so that extmodem can be used with XASTIR.

Please review and let me know what you think!

alejolp commented 8 years ago

hi @Gherynos sorry for the delay, I've been away!

This PR looks promising, but I am having trouble understanding the need for the regexp. I think we can just accept that whatever comes in that looks like a callsign, and avoid the regexp (the call and the dependency).

Also, the callsign ax25 encoding scheme can be placed elsewere, since I predict this function may be of use in the future. At least a public static or global function, somewhere in an utility cpp file.

Thanks!

Ale

alejolp commented 8 years ago

I still need to be convinced to include libax25 as a dependency, but it includes ax25_ntoa and ax25_aton which is what you did here.

gherynos commented 8 years ago

Hi @alejolp,

no worries and thanks for your comments.

The regexp was a convenient way to check if the address contained the SSID and to extract the two components; it can be easily removed though.

Good point about the ax25 encoding procedures: I'll extract them in something like ax25_utils class.

Concerning libax25, I was thinking about it as well, but I didn't want to add additional dependencies, hence the redefinition of the functions.

Thanks, Luca

alejolp commented 8 years ago

Great, thanks!