Implemented FC4 (input register read)

alejoseb / Modbus-STM32-HAL-FreeRTOS

Modbus TCP and RTU, Master and Slave for STM32 using Cube HAL and FreeRTOS

GNU Lesser General Public License v2.1

579 stars 192 forks source link

Implemented FC4 (input register read) #89

Closed ttelik closed 1 year ago

ttelik commented 1 year ago

Implemented using a separate memory block for input registers. (Sorry, no example project yet).

alejoseb commented 1 year ago

Hi, I have some comments:

What is the reasoning for having a separate memory block only for inputs?
An holistic approach should consider different memory regions for coils, registers, and so on.
Also the changes will break existing examples. So as is this PR cannot be merged.

ttelik commented 1 year ago

Hi, Thanks for your note. Unfortunately, I do not have time for a complete solution. You can use this example for inspiration or as a counter-example ;)

In general, most products don't implement the complete address space. It would certainly be possible to use a single memory block with offsets for different regions but seems more elegant to me to use separate blocks.

alejoseb commented 1 year ago

I understand. By now I will keep the library as is, since it needs some analysis for an holistic solution, and also keep the existing examples working