search

aleju / imgaug

Image augmentation for machine learning experiments.
http://imgaug.readthedocs.io
MIT License
14.36k stars 2.43k forks source link

imgaug.augmenters.size.Scale did not give deprecated warning #279

Open Shreeyak opened 5 years ago

Shreeyak commented 5 years ago

I'm using v0.2.8 of imgaug, installed via pip inside a conda env - Ubuntu 16.04.

When I try to use the imgaug.augmenters.size.Scale augmenter, I am not given any deprecation warning. I see in the source code that it has been deprecated and resizer is to be used instead, and a warning saying the same, except I never see it terminal or jupyter notebook

aleju commented 5 years ago

DeprecatedWarnings are sadly by default hidden in python. You have to run your scripts with python -W all filename.py to see them (which of course nobody does). I guess I'll have to change the warning class, otherwise they are kind of pointless.

Shreeyak commented 5 years ago

Yeah, that would be nice. I was extremely surprised not to find the Scale() func I was using in my code in the docs. Had to go digging around and found it in the docs on source code. Maybe we use the same kind of warnings used by tensorflow, pytorch and similar software?

On Fri, Mar 8, 2019, 20:29 Alexander Jung notifications@github.com wrote:

DeprecatedWarnings are sadly by default hidden in python. You have to run your scripts with python -W all filename.py to see them (which of course nobody does). I guess I'll have to change the warning class, otherwise they are kind of pointless.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aleju/imgaug/issues/279#issuecomment-470956873, or mute the thread https://github.com/notifications/unsubscribe-auth/AMNQuTeK8k3jBx_1ewKB3ru3aQ_Ad_o7ks5vUnq_gaJpZM4biCzH .

aleju commented 5 years ago

I was extremely surprised not to find the Scale() func I was using in my code in the docs.

Hm, might have to add deprecated ones to the regular docs too.

Maybe we use the same kind of warnings used by tensorflow, pytorch and similar software?

That sounds like a good idea. Will have to check how they do it.

aleju commented 5 years ago

Deprecation warnings are now no longer silent in master. The implementation is similar to scikit-image. Just a library-specific DeprecationWarning.

Shreeyak commented 5 years ago

Awesome! Thank you so much!

On Sat, Mar 30, 2019 at 9:37 PM Alexander Jung notifications@github.com wrote:

Deprecation warnings are now no longer silent in master. The implementation is similar to scikit-image. Just a library-specific DeprecationWarning.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aleju/imgaug/issues/279#issuecomment-478259857, or mute the thread https://github.com/notifications/unsubscribe-auth/AMNQubCaLh3mia5yF-T84rpQ1zaLQP4Aks5vb4vOgaJpZM4biCzH .