search

alekitto / class-finder

Utility classes to help discover other classes/namespaces
https://alekitto.github.io/class-finder/
MIT License
27 stars 5 forks source link

add filter for files #10

Closed alleknalle closed 7 months ago

alleknalle commented 7 months ago

@alekitto this is my 'fast' PR for https://github.com/alekitto/class-finder/issues/9. Please let me know what to think about it :-)

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f74bfb2) 90.13% compared to head (7de6ba5) 90.34%. Report is 3 commits behind head on master.

Files Patch % Lines
lib/Iterator/PhpDocumentorIterator.php 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #10 +/- ## ============================================ + Coverage 90.13% 90.34% +0.20% - Complexity 309 311 +2 ============================================ Files 34 34 Lines 669 673 +4 ============================================ + Hits 603 608 +5 + Misses 66 65 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alleknalle commented 7 months ago

@alekitto I've added some tests and reverted the .gitignore and composer.lock changes :-)

alekitto commented 7 months ago

Great! Merged, thanks. Will be released very soon.

alekitto commented 6 months ago

I've ported this to all the filters, it is now exposed as pathFilter and the callback accepts only a string with the full filepath. You can always instantiate an SplFileInfo inside the callback if you really need it.

Released in 0.4.0 Closes #9

alleknalle commented 6 months ago

Great, thanks for the improvement :-)