GetShaderParams errors in console. And the game crashes after re-enabling mods.

[Faznafus]

First issue

After starting a run it immediately spams "GetShaderParams" failed: in console.

Log Details

`[INFO] - Error in "GetShaderParams" call:` `[INFO] - [warn] entity pool array class IsaacRepentance::Entity_Slot [128] is full, overwriting at index 1! (frame count: 0)` `[INFO] - Lua Debug: (ERROR) [Stats+@RenderService] Error during render. ([]) -> No entry found for the given slot. ({"playerIndex":0,"stat":{"addonId":"stats-plus-core","statId":"speed-stat"}})`

Second issue

After re-enabling mods by pressing tab and starting a run the game just crashes.

Log Details

`[INFO] - Lua Debug: (ERROR) [Stats+@API] An error occured during addon registration ([]) -> Provider already registered ({"addon":"stats-plus-essentials","id":"damage-multiplier-provider"})` `[INFO] - Lua Debug: (ERROR) [Stats+@API] An error occured during addon registration ([]) -> Provider already registered. ({"addon":"stats-plus-core","id":"null-provider"})`

I have all DLCs and using latest (1.7.9a) Repentance version.

[aleksander-ciesielski]

hello, thanks for reporting the issue 🙂my findings are:

• the GetShaderParams callback errors are nothing to worry about and are not related to any crashing at all
• I'm also getting crashes with those weird errors about the providers being already registered, and looks like it's due to the mod profiler mod (https://steamcommunity.com/sharedfiles/filedetails/?id=2505060515) - it makes Stats+ behave strangely: scuffed transition animations, incorrect opacity, infinite loops when updating settings in Mod Config Menu and probably some other stuff as well

could you please confirm if it's working as expected if you turn off the mod profiler mod? assuming you have it installed in the first place 😄 thanks

[Faznafus]

My apologize for your waiting so long for a response. Nope, I don't use that mod. But I've installed these mods

Mods List

1. Custom Stage API 2. Mod Config Menu Pure 3. ReactionAPI 4. Doors for improved backdrops 5. reaction_port_pack 6. (REP) Improved Chargebar 7. (REP) Improved Hearts 8. (REP) Stone Wings 9. (REP) Music Mod Callback 10. Better Minimap 11. Da Rules 12. Encyclopedia 13. MiniMAPI 14. External Item Descriptions 15. A improved backdrops 16. Better explosions 17. Dancing Sissy 18. Kissy Longlegs 19. Sewing Machine 20. Enhanced Boss Bars 21. A Pony Synergies 22. Alt Horseman 23. Animated Beggars 24. Animated Costumes 25. Animated Machines 26. AntiCrash - less crashes 27. Antibirth music+++ 28. Better bombs 29. Better Character Menu 30. Better Consistent Lightbeam 31. Birthcake 32. Coming Down 33. Completion Marks 34. Boss Rush Wave Counter 35. Darker Hell 36. Demonic Sigils 37. Even More Shopkeepers 38. Extra Options 39. Extra Animated Portraits 40. Good Trip 41. Limbo Deals 2 42. Old Wardrobe 43. Planetarium Chance 44. Range fix for Bag of Crafting 45. Range fix for Bones & Sword 46. Rare Chests 47. Rare Secret Rooms 48. Rare Super Secret Rooms 49. Rune Room 50. Soundtrack Menu 51. Steal From Shops 52. The Deleted 53. TimeMachine 54. Visible Challenge Unlocks 55. Watch out, laser! 56. Wider mods menu 57. eyeguy's EXTRA NPC 58. off-screen indicators 59. pog for good pills 60. Mod Translator

[v5tge]

I've also noticed this. I did some testing and the "GetShaderParams" failed: appears even if this is the only mod installed. Also tried with this + Mod Config Menu Pure and it's still there. No other issues that I've noticed, but it's still a bit annoying so a fix would be appreciated. Also, about the game crashing after re-enabling mods, it's fairly common if you have a few mods and it can happen not just by starting a run, but by doing almost anything. It's recommended to restart the game and let it run with all mods already enabled from the start. Not sure why this happens, but some mods even display a warning when you start a run suggesting you to restart the game once.

[aleksander-ciesielski]

@v5tge I will look into the shader errors but for now it's a lower priority than those crashes @Faznafus would be great if you could use your mod list to find the mod that is causing these crashes; that would help me narrow down possible root causes

[v5tge]

Thanks but if I understood @Faznafus first coment I don't think you can because I don't think those crashes have anything to do with your mod. The game crashing after enabling or disabling a lot of mods is something that I've experienced as well, even before installing this mod. Once the game starts with all the mods already loaded it's completely stable as I have as many mods as him and your mod works just fine. I say this because of the way he explained tha last part. If the game crashes all the time when he has those mods enabled then it's completely different than what I said.

[Faznafus]

I'm not sure, but when I disabled all mods and left your mod enabled and restarted the game, then re-enabled your mod and tried to start a run, the game crashed. If I perform this operation with any other mod, the game does not crash. I have no idea what it could be. I think the problem is not with mods, but not sure. And logs don't say something

[aleksander-ciesielski]

Thanks for more details @Faznafus 🙂 I've managed to reproduce it, and it turns out it's indeed a problem with the shaders (cc @v5tge); now I suspect they cause most crashes. If I'm being completely honest, I don't understand how they work, and the logic here is based on the same shader usage as in the Planetarium Chance mod, though it looks like I messed up the logic on my part. Looking into it now 👀

For now, you can disable the "Use shader color fix" option which should stop the crashes.

[aleksander-ciesielski]

I added a config migration that automatically disables the "Use shader color fix" option; it's already been released so the option should now be disabled for everyone.

[Faznafus]

@aleksander-ciesielski New error have appeared.😁 When I start a new run, and then exit it to the main menu of the game, and click continue the run or start a new one, the "PostRender" failed is spamming in the console

Log Details

`[INFO] - Error in "PostRender" call: ` `[INFO] - Lua Debug: (ERROR) [Stats+@RenderService] Error during render. ([]) -> No entry found for the given slot. ({"stat":{"addonId":"stats-plus-core","statId":"speed-stat"},"playerIndex":0})`

About the crashes, they still remain for me. I don't know why.😢 Also, I must to say (if this will help somehow) if re-enabling other mods (not by pressing Tab) without touching your mod, then the game will not crash and start a run as it should be

[aleksander-ciesielski]

thanks @Faznafus; really weird that the crashes are still occurring 🤔 unfortunately, I currently have no time to investigate it, so I'll just leave it open and will come back to it once I have some spare time to do so

[aleksander-ciesielski]

hey @Faznafus, I don't know if you're still using the mod, but - if yes - do these crashes still occur? I haven't seen any more crash reports except this issue. I know that everyone is getting those console errors (including me) but they don't crash the game, they're just annoying (especially now with the Repentogon).

thanks 🙂

[aleksander-ciesielski]

closing in favor of #8