search

aleksanderbl29 / docker-pihole-unbound

Run Pi-Hole + Unbound on Docker
https://hub.docker.com/r/aleksanderbl/pihole-unbound
24 stars 6 forks source link

Env $PIHOLE_VERSION #56

Closed afreisinger closed 3 months ago

afreisinger commented 3 months ago

Hi !, very good work! For some reason the Dockerfile does not receive $PIHOLE_VERSION as an argument? You get it in the autobuild.yml. Regards. Adrian

aleksanderbl29 commented 3 months ago

Hi @afreisinger ! Thank you for making me aware of this. I thought i had removed the build arg in all the places that it was left.

The pihole_version is hardcoded in the Dockerfile and it is updated in there when a new update published. I did this to not have to rely on the scheduled github actions and instead publish a new image 1) when available and 2) when I have had the chance to test it in my homelab.

Please do let me know if you see any issues with this approach; I'll happily listen to feedback

afreisinger commented 3 months ago

The logic is perfect !