Allow to update a property in addition to version with the generated version on release

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.

https://aleksandr-m.github.io/gitflow-maven-plugin/

Apache License 2.0

492 stars 182 forks source link

Allow to update a property in addition to version with the generated version on release #170

Closed lukelalo closed 5 years ago

lukelalo commented 5 years ago

This development allows to define a property to be updated when version tags are changed.

It works with the versions-maven-plugin and the tycho-versions-plugin as well.

Fix #151

Regards Pablo García

limkinZero commented 5 years ago

Hi @aleksandr-m

Please, merge this feature.

aleksandr-m commented 5 years ago

Definitely nice to have feature, but this PR doesn't resolve #151. The release-start goal fails with Unable to parse the version string: "${revision}" error. This is happening because version is read from the pom.xml file.

lukelalo commented 5 years ago

Mmm I'll check it. Regards

lukelalo commented 5 years ago

Hi @aleksandr-m,

I've updated the IT test as our goal is to update the property to have it on children modules. I know it isn't exactly what was requested on #151, but combined with flatten maven plugin it should work.

What do you think?

Regards Pablo García

aleksandr-m commented 5 years ago

@lukelalo Do you want to allow to update arbitrary property or can we narrow it to revision only?

Currently using flatten plugin and -DpropertyUpdate=revision the version will be still updated.

lukelalo commented 5 years ago

Hi @aleksandr-m

What I want is to keep sync'd version on revision (or other) property when gitflow maven plugin updates the version number on develop, master and release branches. I'm not sure how could I achieve this with flatten plugin currently.

Regards Pablo García

lukelalo commented 5 years ago

Great! Thanks! 👍

aleksandr-m commented 5 years ago

I've made some adjustments so #151 is also resolved.

@lukelalo Thanks for contributing.