search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
493 stars 181 forks source link

Take 2 Global Settings and User Settings #248

Open nhojpatrick opened 4 years ago

nhojpatrick commented 4 years ago

Another approach to https://github.com/aleksandr-m/gitflow-maven-plugin/pull/244

Adding gitflow.maven.settings.global and gitflow.maven.settings.user as plugin properties.

If -gs is already in the argLine it is skipped, same handling for -s.

nhojpatrick commented 3 years ago

@aleksandr-m any thoughts about this PR, like the maven wrapper detection PR. It defines the variables the parent process automatically detected for -gs or -s, but if they are specified they are skipped. And if they are defined as a property those are used instead.

nhojpatrick commented 3 years ago

@aleksandr-m want to add you as a reviewer and request a review but don't have permissions to do that.

nhojpatrick commented 3 years ago

@aleksandr-m can this also be review and hopefully merged please. This and the other would result vm config and extra pom config.

stefanseifert commented 2 years ago

+1, i hit the same problem when developing the ITs for #323