search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
493 stars 181 forks source link

Add GitHub Actions build #252

Closed beatngu13 closed 4 years ago

beatngu13 commented 4 years ago

While getting familiar with the project for #250, I thought I'd start with contributing a CI build (couldn't finde one?) via GitHub Actions.

There are two issues, which I also experience locally:

What's your take on these?

aleksandr-m commented 4 years ago

The POM says Java version 6, although a dependency (org.codehaus.plexus.classworlds.launcher.Launcher) requires 7.

So it is time to update pom.xml

The integration tests are failing and I couldn't find a contributing guide or similar to see what is necessary to make them pass.

They are failing with fatal: bad revision 'HEAD' error in build.log. Seems like there is no refs folder in .git. Maybe git-dir doesn't work as expected.

See https://github.com/aleksandr-m/gitflow-maven-plugin/actions/runs/221024887.

beatngu13 commented 4 years ago

OK, gonna bump the Java version to 7 (also in the POM and elsewhere if applicable).

Regarding the integration tests: Will dig a little deeper during the weekend and hopefully come up with a fix.

beatngu13 commented 4 years ago

Added some improvements and made the integration tests pass, unfortunately only locally. The build still fails with fatal: bad revision 'HEAD'. I have to further investigate this.

aleksandr-m commented 4 years ago

@beatngu13 I've found out why integrations tests were failing - it was missing git user config.

Thank you very much for initial ci script and discovering that java 7 is required!