search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
490 stars 182 forks source link

Reduce maven-compiler-plugin config by using user properties #279

Closed nhojpatrick closed 2 years ago

nhojpatrick commented 3 years ago

Reduce the verbose config required by maven/xml and use the user properties. My other PR's are based upon this so if merged those changes would disappear.

aleksandr-m commented 3 years ago

What benefit does it bring? Why custom?

nhojpatrick commented 3 years ago

I find it useful and a best practice to pick a project namespace for properties that maven or any plugin wouldn't use. I've had issues were people change one property but no the other, or duplicate an existing entry (often during a merge or rebase). If you enable sortpom then it can automatically group properties for easier management.

If you really don't like it I can revert it from the other PR's too.

aleksandr-m commented 2 years ago

I'm more comfortable with them as they are now