search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
490 stars 182 forks source link

release-finish: misleading commit message #281

Closed bannmann closed 3 years ago

bannmann commented 3 years ago

When release-finish makes the final commit on the release branch before merging to master, the commit message is "Update for next development version" (the commit e0ece71 below, marked in green):

commits

That message is misleading because it is the same one that is used on develop as part of release-start (commit 6753f46). I think the "correct" message for the e0ece71 commit should be something like "Update release branch to production version".

Here are my settings:

<plugin>
    <groupId>com.amashchenko.maven.plugin</groupId>
    <artifactId>gitflow-maven-plugin</artifactId>
    <version>1.14.0</version>
    <configuration>
        <commitDevelopmentVersionAtStart>true</commitDevelopmentVersionAtStart>
        <useSnapshotInRelease>true</useSnapshotInRelease>
        <preReleaseGoals>package -DperformRelease=true</preReleaseGoals>
        <pushRemote>true</pushRemote>
        <commitMessagePrefix>[gitflow] </commitMessagePrefix>
    </configuration>
</plugin>
aleksandr-m commented 3 years ago

@bannmann Commit messages can be changed in pom.

<commitMessages>
  <releaseFinishMessage>Update release branch to production version</releaseFinishMessage>
  <releaseVersionUpdateMessage>Update for next development version</releaseVersionUpdateMessage>
</commitMessages>