search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
490 stars 182 forks source link

Automatically update property project.build.outputTimestamp at release time #286

Closed Jurrie closed 3 years ago

Jurrie commented 3 years ago

I am trying to get my build to be reproducible. For this, you have to supply the project.build.outputTimestamp property. This property needs to be updated at release time.

The maven-release-plugin already does this. This is implemented in cfcc8ca59e483. Maybe gitflow-maven-plugin can implement the same?

aleksandr-m commented 3 years ago

@Jurrie Thanks for pointing this out! Do you think project.build.outputTimestamp should be updated on release-start also, or only when finishing a release?

Jurrie commented 3 years ago

Hi @aleksandr-m, I don't know :) I'm currently trying to get our build to be reproducible, updating plugins etc. I'm not yet at the point where I want to update this property.

I think gitflow-maven-plugin should follow maven-release-plugin here as much as possible. The Maven guide states that the maven-release-plugin updates this property in the same commit where it updates the version. I don't actually know if the property will be updated again when the version is set to -SNAPSHOT.

aleksandr-m commented 3 years ago

1.16.0 is released.