search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
490 stars 182 forks source link

Release-finish merge is merging release-branch into develop instead of master onto develop #289

Closed pennajenna closed 3 years ago

pennajenna commented 3 years ago

https://github.com/aleksandr-m/gitflow-maven-plugin/blob/da562a0730e23e361107de965be61ab6bacff81f/src/main/java/com/amashchenko/maven/plugin/gitflow/GitFlowReleaseFinishMojo.java#L308

When using this, the release-finish is merging release-branch onto master and tagging correctly. Then it merges release-branch onto develop. This doesn't allow for the tag to be on develop. Is there a reason for this?

aleksandr-m commented 3 years ago

@pennajenna Seems same as #213. Can you elaborate what benefit does it bring?

pennajenna commented 3 years ago

Yes, if you merge master into develop, the tag from master is on develop. The way it is now, develop doesn’t have the same tag

Sent from my iPhone

On Apr 21, 2021, at 3:16 PM, Aleksandr Mashchenko @.***> wrote:

 @pennajenna Seems same as #213. Can you elaborate what benefit does it bring?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

pennajenna commented 3 years ago

213 reasons are exactly the same as mine, having that tag on develop is a necessity for me

Jenna

Sent from my iPhone

On Apr 21, 2021, at 4:20 PM, Jenna McCormick @.***> wrote:

Yes, if you merge master into develop, the tag from master is on develop. The way it is now, develop doesn’t have the same tag

Sent from my iPhone

On Apr 21, 2021, at 3:16 PM, Aleksandr Mashchenko @.***> wrote:

 @pennajenna Seems same as #213. Can you elaborate what benefit does it bring?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

pennajenna commented 3 years ago

submitted a PR for this: https://github.com/aleksandr-m/gitflow-maven-plugin/pull/291

pennajenna commented 3 years ago

DUPLICATE of https://github.com/aleksandr-m/gitflow-maven-plugin/issues/213