search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
490 stars 182 forks source link

CommitMessagePrefix got concatenated with messages without a space in the middle #293

Closed bl4ckh4t3 closed 3 years ago

bl4ckh4t3 commented 3 years ago

First of all, thanks for this amazing plugin that resolve a lot of issues found in the jgitflow plugin. I'm using commitMessagePrefix properties to set a default prefix for all the messages in order to mark them as done by the plugin and adding the version too with @{version} placeholder. However I found that the prefix message is concatenated to messages without a space in the middle resulting in [GITFLOW] v5.4.0.5.0Update for next development version even if the property has been set in the following way

<commitMessagePrefix>[GITFLOW] v@{version} </commitMessagePrefix>

Is it possible to change the plugin to add a space between prefix and message?

aleksandr-m commented 3 years ago

See https://issues.apache.org/jira/browse/MNG-5380.

You can use xml:space="preserve"

<commitMessagePrefix xml:space="preserve">[GITFLOW] v@{version} </commitMessagePrefix>
bl4ckh4t3 commented 3 years ago

Hi @aleksandr-m thanks for your comment. I've tried with

<commitMessagePrefix xml:space="preserve>[GITFLOW] v@{version}

but the pom is now broken and every build cause the following error:

Non-parseable POM /Users/bl4ckh4t3/Downloads/demo-version/pom.xml: markup not allowed inside attribute value - illegal < (position: TEXT seen ...<commitMessagePrefix xml:space="preserve>[GITFLOW] v@{version} <... @67:85) @ line 67, column 85

aleksandr-m commented 3 years ago

Seems like there is missing " in "preserve>

aleksandr-m commented 3 years ago

I've added a note about that in the readme.