search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
490 stars 182 forks source link

support for --atomic #304

Open TomaszBelina opened 3 years ago

TomaszBelina commented 3 years ago

The change adds atomicPush property to plugin configuration. If set to true --atomic option is added to git command line.

aleksandr-m commented 3 years ago

@TomaszBelina Do you have a real use-case for that? For me if some push fails, I would probably resolve it manually and not pushing what is already ok is less work to do.

mmusenbr commented 2 years ago

I would have a use-case for this: CI. We trigger everything via CI. So if eg the merge into dev in the later stage of the process fails, I would not only need to resolve that merge failure, but also cleanup everything what has already happened. But to keep to current workflow/functionality I would suggest to do it encapsulated in gitPush/gitPushDelete and either store it or push it immediately.

aleksandr-m commented 2 years ago

@redeamer Not sure I understand the need to clean something up after fail. E.g. you are running the goal with two pushes and second one fails, then resolution is probably as simple as resolve conflicts, merge, delete branch. Or maybe creating some PR with hotfix which can be merged in CI.

And even if you do need to do some cleaning, I cannot see how atomic will change this.