search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
488 stars 180 forks source link

Reload Project and recursively all Modules #324

Closed dirk-kaspar closed 2 years ago

dirk-kaspar commented 2 years ago

The Changes suggested from @beatngu13 in Issue #130

dirk-kaspar commented 2 years ago

Thats the first time I've used BeanShell. So please tell me if I have done something weird or strange :smiley:

aleksandr-m commented 2 years ago

The test seems to hold too much, probably some simple goal would be enough, but it is not a big deal.

Can you think of any negative impact of building all the projects can lead to?

Please squash all changes to single commit and force push to this branch.

dirk-kaspar commented 2 years ago

I would love to see a simpler, more elegant solution! But that was the naive solution to demonstrate our Problem. Building all the projects in this case is reloading all the pom and build the Model; Not an actual build for those modules or am I wrong?

All commits squashed.

aleksandr-m commented 2 years ago

Well, let's see how it behaves in real life then :)

beatngu13 commented 2 years ago

The test seems to hold too much, probably some simple goal would be enough, but it is not a big deal.

This is my gut feeling, too. @dirk-kaspar let's have a look afterwards, maybe we can open another PR improving (i.e. minimizing) the IT.

Can you think of any negative impact of building all the projects can lead to?

Performance, maybe? We didn't do a proper performance test, but since we do a complete rebuild, this might increase execution time. On the other hand: we didn't observe anything becoming slower, at least in our pipelines.

aleksandr-m commented 2 years ago

Thank you. Good job!